lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160603.200712.1655112462975368614.davem@davemloft.net> Date: Fri, 03 Jun 2016 20:07:12 -0400 (EDT) From: David Miller <davem@...emloft.net> To: clabbe.montjoie@...il.com Cc: robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, maxime.ripard@...e-electrons.com, wens@...e.org, linux@...linux.org.uk, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com Subject: Re: [PATCH 1/5] ethernet: add sun8i-emac driver From: LABBE Corentin <clabbe.montjoie@...il.com> Date: Fri, 3 Jun 2016 11:56:26 +0200 > +static int nbdesc_tx = 256; > +module_param(nbdesc_tx, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(nbdesc_tx, "Number of descriptors in the TX list"); > +static int nbdesc_rx = 128; > +module_param(nbdesc_rx, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(nbdesc_rx, "Number of descriptors in the RX list"); Module parameters are not appropriate. Please use the proper ethtool configuration facilities to control the size of the RX and TX queues. Thanks.
Powered by blists - more mailing lists