lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 4 Jun 2016 09:19:19 -0300
From:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:	David Miller <davem@...emloft.net>, fengguang.wu@...el.com
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 17/24] DockBook: net/core/skbuff.c:4404:
 warning: No description found for parameter 'mtu'

Em 04-06-2016 02:57, David Miller escreveu:
> From: kbuild test robot <fengguang.wu@...el.com>
> Date: Sat, 4 Jun 2016 08:48:17 +0800
>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
>> head:   330348d94223346f855357fab2517f6c903001c7
>> commit: ae7ef81ef000adeee7a87585b9135ff8a8064acc [17/24] skbuff: introduce skb_gso_validate_mtu
>> reproduce: make htmldocs
>>
>> All warnings (new ones prefixed by >>):
>>
>>    include/linux/skbuff.h:928: warning: No description found for parameter 'sk'
>>    include/net/sock.h:449: warning: No description found for parameter 'sk_padding'
>>    include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'
>>>> net/core/skbuff.c:4404: warning: No description found for parameter 'mtu'
>>    net/core/gen_stats.c:65: warning: No description found for parameter 'padattr'
>>    net/core/gen_stats.c:100: warning: No description found for parameter 'padattr'
>
> Fixed as follows:
>
> ====================
> net: Add docbook description for 'mtu' arg to skb_gso_validate_mtu()
>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/core/skbuff.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index b6e0f95..e7ec6d3 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4399,6 +4399,7 @@ EXPORT_SYMBOL_GPL(skb_gso_transport_seglen);
>   * skb_gso_validate_mtu - Return in case such skb fits a given MTU
>   *
>   * @skb: GSO skb
> + * @mtu: MTU to validate against
>   *
>   * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU
>   * once split.
>

Thanks David.

Powered by blists - more mailing lists