netdev - Re: [RFC v3 1/3] NET: PHY: adds driver for Intel XWAY PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5752F36A.4050007@gmail.com>
Date:	Sat, 4 Jun 2016 17:27:38 +0200
From:	Daniel Schwierzeck <daniel.schwierzeck@...il.com>
To:	"Langer, Thomas" <thomas.langer@...el.com>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>
Cc:	"alexander.stein@...tec-electronic.com" 
	<alexander.stein@...tec-electronic.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"john@...ozen.org" <john@...ozen.org>,
	"openwrt@...sin.me" <openwrt@...sin.me>,
	"Mehrtens, Hauke" <hauke.mehrtens@...el.com>,
	"eckert.florian@...glemail.com" <eckert.florian@...glemail.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RFC v3 1/3] NET: PHY: adds driver for Intel XWAY PHY



Am 04.06.2016 um 16:43 schrieb Langer, Thomas:
> Hello Hauke,
> 
> [...]
>> +
>> +static int xway_gphy_ack_interrupt(struct phy_device *phydev)
>> +{
>> +	int reg;
>> +
>> +	/**
>> +	 * Possible IRQ numbers:
>> +	 * - IM3_IRL18 for GPHY0
>> +	 * - IM3_IRL17 for GPHY1
> 
> These are references to the SoC interrupts.
> 
>> +	 *
>> +	 * Due to a silicon bug IRQ lines are not really independent from
>> +	 * each other. Sometimes the two lines are driven at the same time
>> +	 * if only one GPHY core raises the interrupt.
> 
> So this errata sounds like a SoC errata, not an errata for the PHY.
> 

this comment is a remnant from the first driver version which was mainly
used on a VRX200 SoC. But interrupts are generally working fine so this
comment should be removed.


-- 
- Daniel