netdev - Re: [net] fq_codel: fix NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Jun 2016 12:40:32 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Stas Nichiporovich <stasn77@...il.com>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [net] fq_codel: fix NET_XMIT_CN behavior

On Sat, 2016-06-04 at 21:03 +0200, Florian Westphal wrote:

> Is skb still valid here? AFAICS its possible that fq_codel_drop() drops it.
> 
> Other than that this looks good, thanks Eric!

You are are right. skb is guaranteed to be valid only when we return
NET_XMIT_SUCCESS.

I'll send a V2, thanks !