netdev - RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR11MB0088CFB314E7498E1CC38E71975B0@CO2PR11MB0088.namprd11.prod.outlook.com>
Date:	Sun, 5 Jun 2016 12:03:25 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Michal Schmidt <mschmidt@...hat.com>,
	netdev <netdev@...r.kernel.org>
CC:	Ariel Elior <Ariel.Elior@...gic.com>
Subject: RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

> > Since implementing VLAN filtering in commit 05cc5a39ddb74
> > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN
> > while the interface is down.
> 
> Hi Michal - thanks; I'll review this one on Sunday.

I'm a bit worried about the fact we're hiding actual issues -
E.g., if for some [unexpected] reason a vlan configuration ramrod would
fail, the only effect it will have is that we'll try [and probably fail] to
change HW into any-vlan mode; We won't propagate the error back to
caller.

Having written that, since we can't really avoid this in some scenarios
 [I.e., if we accept the command while down and configure it later while
up we can't do anything with an error if it occurs], I guess that's the pros
out-weight the cons here.

Thanks.

Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>