netdev - Re: [PATCH v2 net] fq_codel: fix NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465160087.2968.51.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Sun, 05 Jun 2016 13:54:47 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Florian Westphal <fw@...len.de>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Stas Nichiporovich <stasn77@...il.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

On Sun, 2016-06-05 at 13:30 -0700, Cong Wang wrote:
> On Sat, Jun 4, 2016 at 12:55 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > My prior attempt to fix the backlogs of parents failed.
> >
> > If we return NET_XMIT_CN, our parents wont increase their backlog,
> > so our qdisc_tree_reduce_backlog() should take this into account.
> >
> 
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>

BTW, we might need a similar fix in sch_fq.c