netdev - Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2e1eb44-a0ef-5b41-2dc0-6823cbe4f392@cogentembedded.com>
Date:	Mon, 6 Jun 2016 19:41:16 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
Cc:	alexei.starovoitov@...il.com, john.fastabend@...il.com,
	jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net, cls: allow for deleting all filters for
 given parent

On 06/05/2016 08:47 PM, Daniel Borkmann wrote:

>> On 6/4/2016 7:24 PM, Daniel Borkmann wrote:
> [...]
>>
>>     Need a comment here, something like /* FALL THRU */.
>
> Hmm, not really, I think it's obvious enough.

    Well, at least the *switch* example in the CodingStyle chapter 1 has such 
comment (though there's no explicit statement on this matter).

>>> +        default:
>>>              return -ENOENT;
>>> -        prio = TC_H_MAKE(0x80000000U, 0U);
>>> +        }
>>>      }
[...]

MBR, Sergei