[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 11:42:12 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Pramod Kumar <pramod.kumar@...adcom.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Kishon Vijay Abraham I <kishon@...com>,
"David S. Miller" <davem@...emloft.net>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
bcm-kernel-feedback-list@...adcom.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Jon Mason <jonmason@...adcom.com>
Subject: Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support
On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the
> interface from the iproc mdio mux driver to enable the devices
> respective phys.
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jon Mason <jonmason@...adcom.com>
> Signed-off-by: Pramod Kumar <pramod.kumar@...adcom.com>
> ---
> drivers/phy/Kconfig | 8 +++
> drivers/phy/Makefile | 2 +-
> drivers/phy/phy-bcm-ns2-pcie.c | 115 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 124 insertions(+), 1 deletion(-)
> create mode 100644 drivers/phy/phy-bcm-ns2-pcie.c
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index b869b98..01fb93b 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE
>
> source "drivers/phy/tegra/Kconfig"
>
> +config PHY_NS2_PCIE
> + tristate "Broadcom Northstar2 PCIe PHY driver"
> + depends on OF && MDIO_BUS_MUX_BCM_IPROC
> + select GENERIC_PHY
> + default ARCH_BCM_IPROC
Are not you missing a dependency on PHYLIB too to provide
mdio_module_register() etc. (at least make it build)?
--
Florian
Powered by blists - more mailing lists