netdev - Re: [PATCH net-next] cxgb4: Reduce resource allocation in kdump kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2016 15:31:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	leedom@...lsio.com, hariprasad@...lsio.com, netdev@...r.kernel.org,
	nirranjan@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: Reduce resource allocation in kdump
 kernel

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Sat, 4 Jun 2016 13:24:43 +0000

>> When is_kdump_kernel() is true, reduce our memory footprint by only using a
>> single "Queue Set" and Forcing Master so we can reinitialize the Firmware/Chip.
>> 
>> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
> ...
>>         if (q10g > netif_get_num_default_rss_queues())
>>                 q10g = netif_get_num_default_rss_queues();
>> 
>> +       /* Reduce memory usage in kdump environment by using only one queue
>> +        * and disable all offload.
>> +        */
>> +       if (is_kdump_kernel()) {
>> +               q10g = 1;
>> +               adap->params.offload = 0;
>> +       }
>> +
> 
> Sounds like a common issue that might interest other devices as well.
> Perhaps we should change netif_get_num_default_rss_queues() to return 1
> when called from a kdump kernel?

Yeah that might make sense.