netdev - Re: [PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607002212.GO12165@lunn.ch>
Date:	Tue, 7 Jun 2016 02:22:12 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emlof.net,
	vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next v2 2/5] net: dsa: Initialize
 ds->enabled_port_mask and ds->phys_mii_mask

> @@ -304,6 +312,18 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
>  	if (err < 0)
>  		return err;
>  
> +	if (!ds->slave_mii_bus && ds->drv->phy_read) {
> +		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
> +		if (!ds->slave_mii_bus)
> +			return err;
> +
> +		dsa_slave_mii_bus_init(ds);
> +
> +		err = mdiobus_register(ds->slave_mii_bus);
> +		if (err < 0)
> +			return err;
> +	}
> +
>  	for (index = 0; index < DSA_MAX_PORTS; index++) {
>  		port = ds->ports[index].dn;
>  		if (!port)

Hi Florian

This hunk does not seem to fit in this patch.

It is also missing the unregister in dsa_ds_unapply().

   Andrew