netdev - Re: [PATCH net 1/2] net: cls_u32: fix error code for invalid flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5756EC49.10000@gmail.com>
Date:	Tue, 7 Jun 2016 08:46:17 -0700
From:	John Fastabend <john.fastabend@...il.com>
To:	Jakub Kicinski <jakub.kicinski@...ronome.com>,
	netdev@...r.kernel.org
Cc:	john.r.fastabend@...el.com, sridhar.samudrala@...el.com
Subject: Re: [PATCH net 1/2] net: cls_u32: fix error code for invalid flags

On 16-06-06 08:16 AM, Jakub Kicinski wrote:
> 'err' variable is not set in this test, we would return whatever
> previous test set 'err' to.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  net/sched/cls_u32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
> index 079b43b3c5d2..b17e090f2fe1 100644
> --- a/net/sched/cls_u32.c
> +++ b/net/sched/cls_u32.c
> @@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
>  	if (tb[TCA_U32_FLAGS]) {
>  		flags = nla_get_u32(tb[TCA_U32_FLAGS]);
>  		if (!tc_flags_valid(flags))
> -			return err;
> +			return -EINVAL;
>  	}
>  
>  	n = (struct tc_u_knode *)*arg;
> 

Yep, I agree it is nice to get an error on this case.

Acked-by: John Fastabend <john.r.fastabend@...el.com>