netdev - Re: [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5756AC53.70406@cumulusnetworks.com>
Date:	Tue, 7 Jun 2016 13:13:23 +0200
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net] bridge: Don't insert unnecessary local fdb entry on
 changing mac address

On 06/07/2016 12:14 PM, Toshiaki Makita wrote:
> The missing br_vlan_should_use() test caused creation of an unneeded
> local fdb entry on changing mac address of a bridge device when there is
> a vlan which is configured on a bridge port but not on the bridge
> device.
> 
> Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> ---

Good catch,

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>