netdev - Re: [PATCH net] net: sched: fix tc_should_offload for specific clsact classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160607.170007.2097162678054823317.davem@davemloft.net>
Date:	Tue, 07 Jun 2016 17:00:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	john.fastabend@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sched: fix tc_should_offload for specific
 clsact classes

From: Daniel Borkmann <daniel@...earbox.net>
Date: Mon,  6 Jun 2016 22:50:39 +0200

> When offloading classifiers such as u32 or flower to hardware, and the
> qdisc is clsact (TC_H_CLSACT), then we need to differentiate its classes,
> since not all of them handle ingress, therefore we must leave those in
> software path. Add a .tcf_cl_offload() callback, so we can generically
> handle them, tested on ixgbe.
> 
> Fixes: 10cbc6843446 ("net/sched: cls_flower: Hardware offloaded filters statistics support")
> Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support")
> Fixes: a1b7c5fd7fe9 ("net: sched: add cls_u32 offload hooks for netdevs")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied, thanks Daniel.