netdev - Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1606080741541.14228@shri-linux.eng.vmware.com>
Date:	Wed, 8 Jun 2016 07:43:16 -0700 (PDT)
From:	Shrikrishna Khare <skhare@...are.com>
To:	Thomas Hellstrom <thellstrom@...are.com>
cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	pv-drivers@...are.com, Jin Heo <heoj@...are.com>
Subject: Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO
 packets



On Wed, 8 Jun 2016, Thomas Hellstrom wrote:

> >  				mss = rcdlro->mss;
> >  				if (unlikely(segCnt <= 1))
> >  					segCnt = 0;
> 
> Based on this code, it looks like it can handle the case without taking
> down the kernel completely, so instead of a
> "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()?

Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent 
out revised patch.