netdev - Re: [PATCH v2 net] l2tp: fix configuration passed to setup_udp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Jun 2016 11:12:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	g.nault@...halink.fr
Cc:	netdev@...r.kernel.org, tom@...bertland.com, jchapman@...alix.com
Subject: Re: [PATCH v2 net] l2tp: fix configuration passed to
 setup_udp_tunnel_sock()

From: Guillaume Nault <g.nault@...halink.fr>
Date: Wed, 8 Jun 2016 12:59:17 +0200

> Unused fields of udp_cfg must be all zeros. Otherwise
> setup_udp_tunnel_sock() fills ->gro_receive and ->gro_complete
> callbacks with garbage, eventually resulting in panic when used by
> udp_gro_receive().
 ...
> v2: use empty initialiser instead of "{ NULL }" to avoid relying on
>     first field's type.
> 
> Fixes: 38fd2af24fcf ("udp: Add socket based GRO and config")
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Applied and queued up for -stable, thanks.