netdev - Re: [PATCH net v2] sfc: report supported link speeds on SFP connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160608.111914.164051676271541750.davem@davemloft.net>
Date:	Wed, 08 Jun 2016 11:19:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarod@...hat.com
Cc:	bkenward@...arflare.com, linux-kernel@...r.kernel.org,
	linux-net-drivers@...arflare.com, ecree@...arflare.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net v2] sfc: report supported link speeds on SFP
 connections

From: Jarod Wilson <jarod@...hat.com>
Date: Wed, 8 Jun 2016 09:41:14 -0400

> On Tue, Jun 07, 2016 at 05:20:16PM -0400, Jarod Wilson wrote:
>> On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
>> > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
>> > > 7000-series SFC NICs connected with an SFP+ module currently fail to
>> > > report any supported link speeds.
>> > > 
>> > > Reported-by: Jarod Wilson <jarod@...hat.com>
>> > > Signed-off-by: Bert Kenward <bkenward@...arflare.com>
>> > 
>> > Had a feeling my cut might not have been quite right. Looks good to me.
>> > 
>> > Reviewed-by: Jarod Wilson <jarod@...hat.com>
>> 
>> ...however, upon testing, there's a gotcha. This results in my 10Gbps sfc
>> nic reporting that it supports 40Gbps:
>> 
>> $ ethtool ens4f0
>> Settings for ens4f0:
>> 	Supported ports: [ FIBRE ]
>> 	Supported link modes:   1000baseT/Full
>> 	                        10000baseT/Full
>> 	                        40000baseKR4/Full
> 
> This turned out to be a flub on my part. My local tree wasn't clean, had
> some lingering test/debug crap in it that I thought I'd removed, but
> clearly, hadn't. With that removed, we're all good here.
> 
> Tested-by: Jarod Wilson <jarod@...hat.com>

Thanks for following up.

Applied, thanks everyone.