netdev - Re: [patch -next] qed: potential overflow in qed_cxt_src_t2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160608.003336.1269899649820841663.davem@davemloft.net>
Date:	Wed, 08 Jun 2016 00:33:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
	everest-linux-l2@...gic.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] qed: potential overflow in qed_cxt_src_t2_alloc()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 7 Jun 2016 15:04:16 +0300

> In the current code "ent_per_page" could be more than "conn_num" making
> "conn_num" negative after the subtraction.  In the next iteration
> through the loop then the negative is treated as a very high positive
> meaning we don't put a limit on "ent_num".  It could lead to memory
> corruption.
> 
> Fixes: dbb799c39717 ('qed: Initialize hardware for new protocols')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks.