netdev - Re: [PATCH] ping: ICMP error replies while errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 10:53:43 +0900
From:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
To:	"Jason A. Donenfeld" <Jason@...c4.com>, netdev@...r.kernel.org,
	hideaki@...hifuji.org
Cc:	hideaki.yoshifuji@...aclelinux.com
Subject: Re: [PATCH] ping: ICMP error replies while errno < 0 is a hard error

Hi,

Jason A. Donenfeld wrote:
> There are some odd conditions in which a device will return an error for
> sendto, while at the same time an ICMP error response is generated. In
> this case, with the current code, the packet is retransmitted in a
> flood, which is not what anybody wants. In fact, when these two
> conditions occur, we want to treat the packet as a "hard local error"
> and do the ordinary pause as before. The reasoning is that if we did
> receive an ICMP error message, then the packet was transmitted, and so
> it should be accounted for. But, since we also received an errno, this
> should be reported to the user, as something is wonky with their network
> interface.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Applied. Thank you.

-- 
Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION