netdev - Re: [PATCH] net: diag: add missing declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465481446.7945.40.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 09 Jun 2016 07:10:46 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:	linux-kernel@...ts.codethink.co.uk,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: diag: add missing declarations

On Thu, 2016-06-09 at 12:17 +0100, Ben Dooks wrote:
> The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
> seem to have been missed from the include/linux/inet_diag.h header
> file. Add them to fix the following warnings:
> 
> net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
> net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  include/linux/inet_diag.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
> index 7c27fa1..feb04ea 100644
> --- a/include/linux/inet_diag.h
> +++ b/include/linux/inet_diag.h
> @@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net,
>  
>  int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk);
>  
> +void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk);
> +
> +int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
> +			     struct inet_diag_msg *r, int ext,
> +			     struct user_namespace *user_ns);
> +
>  extern int  inet_diag_register(const struct inet_diag_handler *handler);
>  extern void inet_diag_unregister(const struct inet_diag_handler *handler);
>  #endif /* _INET_DIAG_H_ */

Please send a v2, deleting them from net/sctp/sctp_diag.c

Thanks.