netdev - Re: [PATCH v3 net-next 3/5] net: vrf: call netdev_lockdep_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2016 09:05:12 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v3 net-next 3/5] net: vrf: call
 netdev_lockdep_set_classes()

On 6/9/16 8:45 AM, Eric Dumazet wrote:
> In case a qdisc is used on a vrf device, we need to use different
> lockdep classes to avoid false positives.
>
> Use the new netdev_lockdep_set_classes() generic helper.
>
> Reported-by: David Ahern <dsa@...ulusnetworks.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  drivers/net/vrf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index e3e693bf0dec..b82e3527924e 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -661,7 +661,7 @@ static int vrf_dev_init(struct net_device *dev)
>
>  	/* similarly, oper state is irrelevant; set to up to avoid confusion */
>  	dev->operstate = IF_OPER_UP;
> -
> +	netdev_lockdep_set_classes(dev);
>  	return 0;
>
>  out_rth:
>

Works for me. Thanks, Eric.

Tested-by: David Ahern <dsa@...ulusnetworks.com>