lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACna6rxZEnPydDfzpyE2NXz1FSj=PVmT+vWuJ_PdScvGnBmNfQ@mail.gmail.com> Date: Thu, 9 Jun 2016 18:48:31 +0200 From: Rafał Miłecki <zajec5@...il.com> To: Kalle Valo <kvalo@...eaurora.org> Cc: Brett Rudley <brudley@...adcom.com>, Arend van Spriel <arend@...adcom.com>, "Franky (Zhenhui) Lin" <frankyl@...adcom.com>, Hante Meuleman <meuleman@...adcom.com>, Pieter-Paul Giesberts <pieterpg@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, brcm80211 development <brcm80211-dev-list@...adcom.com>, Network Development <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: brcmfmac: rework function picking free BSS index On 9 June 2016 at 18:30, Kalle Valo <kvalo@...eaurora.org> wrote: > Kalle Valo <kvalo@...eaurora.org> writes: > >> Rafał Miłecki wrote: >>> The old implementation was overcomplicated and slightly bugged in some >>> corner cases. >>> >>> Consider following state of BSS-es (limited to 6 for simplification): >>> drvr->iflist[0]: { bsscfgidx:0, ndev->name:wlan1, } >>> drvr->iflist[1]: (null) >>> drvr->iflist[2]: { bsscfgidx:2, ndev->name:wlan1-1, } >>> drvr->iflist[3]: { bsscfgidx:3, ndev->name:wlan1-2, } >>> drvr->iflist[4]: (null) >>> drvr->iflist[5]: (null) >>> In such case the next AP interface should bsscfgidx 4 (we don't use 1 as >>> it's reserved for P2P). >>> >>> With old code the loop iterations were following: >>> [ifidx = 0] [bsscfgidx = 2] [highest = 2] >>> [ifidx = 1] [bsscfgidx = 2] [highest = 2] available = true >>> [ifidx = 2] [bsscfgidx = 2] [highest = 2] bsscfgidx = highest + 1 >>> [ifidx = 3] [bsscfgidx = 3] [highest = 2] bsscfgidx = highest + 1 >>> [ifidx = 4] [bsscfgidx = 3] [highest = 2] available = true >>> [ifidx = 5] [bsscfgidx = 3] [highest = 2] available = true >>> There were 2 obvious problems: >>> 1) Having empty BSS at index 1 was resulting in available being always >>> set to true, even if we would run out of BSS-es. >>> 2) Calculated bsscfgidx was invalid (3 instead of 4) resulting in driver >>> not being able to create the 4th AP interface. >>> >>> New code is simpler, placed in file where it's really used, handles >>> running out of free BSS-es and allows using 4 interfaces at the same >>> time. It also looks for the first free BSS instead of one after the last >>> in use. It works well with current driver (which doesn't allow deleting >>> interfaces) and should be future proof (if we ever allow deleting). >>> >>> Signed-off-by: Rafał Miłecki <zajec5@...il.com> >> >> Thanks, 1 patch applied to wireless-drivers-next.git: >> >> d02fb8f14b2d brcmfmac: rework function picking free BSS index > > Now that patchwork.kernel.org is finally updated and I fixed my python > script, this is the first time I applied a patch using UTF-8 charset > directly from patchwork. As it's not exactly easy to get UTF-8 support > right in python, I would very much like to hear if there any issues > either with the commit below or the email above. > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=d02fb8f14b2d Look fine, thanks! -- Rafał
Powered by blists - more mailing lists