netdev - Re: [PATCH net-next] sit: remove unnecessary protocol check in ipip6_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160609.112351.1413951064710022309.davem@davemloft.net>
Date:	Thu, 09 Jun 2016 11:23:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	simon.horman@...ronome.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sit: remove unnecessary protocol check in
 ipip6_tunnel_xmit()

From: Simon Horman <simon.horman@...ronome.com>
Date: Thu,  9 Jun 2016 18:03:34 +0900

> ipip6_tunnel_xmit() is called immediately after checking that
> skb->protocol is  htons(ETH_P_IPV6) so there is no need
> to check it a second time.
> 
> Found by inspection.
> 
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> Reviewed-by: Dinan Gunawardena <dinan.gunawardena@...ronome.com>

Looks good, applied, thanks Simon.