netdev - Re: [PATCH net-next 2/4] net: vrf: call netdev_lockdep_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLH-6EzyOwQ67owxhYOnA9CPyoN_Y0Pf2EtBpBc_+=zEw@mail.gmail.com>
Date:	Wed, 8 Jun 2016 18:52:15 -0700
From:	Eric Dumazet <edumazet@...gle.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 2/4] net: vrf: call netdev_lockdep_set_classes()

On Wed, Jun 8, 2016 at 6:49 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> On 6/8/16 7:43 PM, Eric Dumazet wrote:
>>
>> For this one, it looks vrf misses the _xmit_lock lockdep support.
>>
>> We might need to factorize the code found for example in
>> bond_set_lockdep_class_one()
>>
>> Have you run lockdep before ? Strange that these issues were not
>> spotted earlier.
>
>
> Standard config for non-performance builds has the locking and rcu debugs
> enabled. You posted the patches on Jun 6; this morning was the first build
> with them and first run hit it.

Then you were simply avoiding the deadlock detection for some reason.

Two ->_xmit_more with same class would detect an issue. This has
nothing to do with my patches.

(Note they are all false positives... of course)