netdev - Re: [PATCH] stmmac: fix parameter to dwmac4_set_umac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f29642a3-efaa-8f70-2f37-69ec0ce19c2e@st.com>
Date:	Thu, 9 Jun 2016 07:32:32 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>,
	<linux-kernel@...ts.codethink.co.uk>
CC:	Alexandre Torgue <alexandre.torgue@...com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] stmmac: fix parameter to dwmac4_set_umac_addr()

On 6/8/2016 8:21 PM, Ben Dooks wrote:
> The dwmac4_set_umac_addr() takes a struct mac_device_info as
> the first parameter, but is being passed a ioaddr instead from
> dwmac4_set_filter(). Fix the warning/bug by changing the first
> parameter.
>
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46:    expected struct mac_device_info *hw
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46:    got void [noderef] <asn:2>*ioaddr
>
> Note, only compile tested this as do not have any
> hardware with it in.
>
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: netdev@...r.kernel.org

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> index 4f7283d..44da877 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
> @@ -156,7 +156,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
>  		struct netdev_hw_addr *ha;
>
>  		netdev_for_each_uc_addr(ha, dev) {
> -			dwmac4_set_umac_addr(ioaddr, ha->addr, reg);
> +			dwmac4_set_umac_addr(hw, ha->addr, reg);
>  			reg++;
>  		}
>  	}
>