netdev - Re: [patch net 2/2] mlxsw: spectrum: Don't sleep during ndo_get_phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160609091648.GA1866@nanopsycho.amit.cz>
Date:	Thu, 9 Jun 2016 11:16:48 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"idosch@...lanox.com" <idosch@...lanox.com>,
	"eladr@...lanox.com" <eladr@...lanox.com>,
	"yotamg@...lanox.com" <yotamg@...lanox.com>,
	"nogahf@...lanox.com" <nogahf@...lanox.com>,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>
Subject: Re: [patch net 2/2] mlxsw: spectrum: Don't sleep during
 ndo_get_phys_port_name()

Thu, Jun 09, 2016 at 10:50:16AM CEST, Yuval.Mintz@...gic.com wrote:
>> When rtnl_fill_ifinfo() is called for a certain netdevice it queries its various
>> parameters such as switch id and physical port name. The function might get
>> called in an atomic context, which means the underlying driver must not sleep
>
>Is Documentation/networking/netdevices.txt a deprecated file?
>If not, perhaps we should update such information there; Otherwise its trial
>and  error for everyone.

Looks like Documentation/networking/netdevices.txt needs a lot of work
to make it up to date. Would perhaps make sense to move this info
directly to the initial comment of struct net_device_ops.