netdev - Re: [PATCH net] packet: compat support for sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57593C5E.8090303@iogearbox.net>
Date:	Thu, 09 Jun 2016 11:52:30 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	netdev@...r.kernel.org
CC:	davem@...emloft.net, deller@....de,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] packet: compat support for sock_fprog

On 06/07/2016 06:06 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
>
> Socket option PACKET_FANOUT_DATA takes a struct sock_fprog as argument
> if PACKET_FANOUT has mode PACKET_FANOUT_CBPF. This structure contains
> a pointer into user memory. If userland is 32-bit and kernel is 64-bit
> the two disagree about the layout of struct sock_fprog.
>
> Add compat setsockopt support to convert a 32-bit compat_sock_fprog to
> a 64-bit sock_fprog. This is analogous to compat_sock_fprog support for
> SO_REUSEPORT added in commit 1957598840f4 ("soreuseport: add compat
> case for setsockopt SO_ATTACH_REUSEPORT_CBPF").
>
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Looks good to me, thanks Willem!

Acked-by: Daniel Borkmann <daniel@...earbox.net>