lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ab991904-5443-1b2a-cae0-ff9697690f05@codethink.co.uk> Date: Thu, 9 Jun 2016 13:11:45 +0100 From: Ben Dooks <ben.dooks@...ethink.co.uk> To: Daniel Borkmann <daniel@...earbox.net>, linux-kernel@...ts.codethink.co.uk Cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org Subject: Re: [PATCH] net: ipconfgi: add declaration for ic_addrservaddr On 09/06/16 12:35, Daniel Borkmann wrote: > On 06/09/2016 01:07 PM, Ben Dooks wrote: >> The symbol ic_addrservaddr is not static, but has no declaration >> to match. Since the similar variables are all exported, add this >> one to the header file as well. >> >> This fixes the following warning: >> >> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not >> declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk> > > Well, how about making it actually static if it's only used > from ipconfig.c ? The only reason is that I thought someone might want to use it in the future. I have no particular insight though. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius
Powered by blists - more mailing lists