lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fusm8rbd.fsf@ketchup.mtl.sfl> Date: Thu, 09 Jun 2016 08:44:38 -0400 From: Vivien Didelot <vivien.didelot@...oirfairelinux.com> To: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...ts.codethink.co.uk Cc: Ben Dooks <ben.dooks@...ethink.co.uk>, Andrew Lunn <andrew@...n.ch>, Lennert Buytenhek <buytenh@...tstofly.org>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: make unexported functions static Hi Ben, Ben Dooks <ben.dooks@...ethink.co.uk> writes: > The driver has a number of functions that are not exported or > declared elsewhere, so make them static to avoid the following > warnings from sparse: > > drivers/net/dsa/mv88e6xxx.c:113:5: warning: symbol 'mv88e6xxx_reg_read' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:167:5: warning: symbol 'mv88e6xxx_reg_write' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:231:5: warning: symbol 'mv88e6xxx_set_addr' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:367:6: warning: symbol 'mv88e6xxx_ppu_state_init' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:3157:5: warning: symbol 'mv88e6xxx_phy_page_read' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:3169:5: warning: symbol 'mv88e6xxx_phy_page_write' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:3583:26: warning: symbol 'mv88e6xxx_switch_driver' was not declared. Should it be static? > drivers/net/dsa/mv88e6xxx.c:3621:5: warning: symbol 'mv88e6xxx_probe' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk> Most of them are fixed or being handled in net-next. I don't know if net should diverge or if it can live with these warnings... Thanks, Vivien
Powered by blists - more mailing lists