netdev - Re: [PATCH net-next] net/mlx4_en: mlx4_en_netpoll() should schedule TX, not RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160609.222443.1427710681512363032.davem@davemloft.net>
Date:	Thu, 09 Jun 2016 22:24:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ttoukan.linux@...il.com, ebiederm@...ssion.com, maze@...gle.com,
	edumazet@...gle.com, netdev@...r.kernel.org, willemb@...gle.com,
	eugenia@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_en: mlx4_en_netpoll() should
 schedule TX, not RX

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 03 Jun 2016 11:52:49 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> I am not sure mlx4_en_netpoll() is doing anything useful right now.
> 
> mlx4 has different NAPI structures for RX and TX, and netpoll only wants
> to drain TX queues.
> 
> Lets schedule NAPI polls on TX, not RX.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>

Applied.