netdev - Re: [PATCH] net: cavium: liquidio: Remove deprecated create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160609.234907.1896722620762197262.davem@davemloft.net>
Date:	Thu, 09 Jun 2016 23:49:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhaktipriya96@...il.com
Cc:	derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com, tj@...nel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: cavium: liquidio: Remove deprecated
 create_workqueue

From: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Date: Wed, 8 Jun 2016 01:47:59 +0530

> alloc_workqueue replaces deprecated create_workqueue().
> 
> A dedicated workqueue has been used since the workitem viz
> (&lio->txq_status_wq.wk.work which maps to octnet_poll_check_txq_status)
> is involved in a brief poll routine for checking transmit queue status
> and is an intergral part of normal device operation.
> WQ_MEM_RECLAIM has been set to guarantee forward progress under memory
> pressure, which is a requirement here.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary.
> 
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Applied.