netdev - Re: [PATCH next] sched: remove NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465568918.7945.51.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Fri, 10 Jun 2016 07:28:38 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev@...r.kernel.org, a@...table.cc, sw@...onwunderlich.de,
	mareklindner@...mailbox.ch, sven@...fation.org
Subject: Re: [PATCH next] sched: remove NET_XMIT_POLICED

On Fri, 2016-06-10 at 14:21 +0200, Florian Westphal wrote:
> ... its not returned anywhere.
> 
> BATMAN uses it as an intermediate return value to signal
> forwarding vs. buffering, but it will not return POLICED to
> callers outside of BATMAN.
> 
> sch_atm uses it, but on closer look its not returned either since
> the initialisation is always overwritten with qdisc_enqueue() retval.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

I have a patch series removing couples of qdisc_unthrottled() and
qdisc_throttled() which are pretty expensive for very little gain.