netdev - Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160611.104226.1571085838142610714.davem@davemloft.net>
Date:	Sat, 11 Jun 2016 10:42:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	mario_limonciello@...l.com, hayeswang@...ltek.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, pali.rohar@...il.com,
	anthony.wong@...onical.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH v6] r8152: Add support for setting pass through MAC
 address on RTL8153-AD

From: Andrew Lunn <andrew@...n.ch>
Date: Sat, 11 Jun 2016 17:39:21 +0200

> What is still open is do we want to accept it at all? Do we accept the
> concept of putting the same MAC address on multiple interfaces at
> hotplug time? Do we trust BIOS vendors to not keep changing DSDT
> property name, since it is not standardised?
> 
> Do we want this at all should be decided by somebody more senior then
> those passing comments on the code.

Indeed, I think the behavior of using the same MAC address on multiple
interfaces if we plug several of these in at once is not good.

We shouldn't behave this way just because the Microsoft driver does.