netdev - Re: [PATCH v2 -next] sched: remove NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160611225706.GA16798@breakpoint.cc>
Date:	Sun, 12 Jun 2016 00:57:06 +0200
From:	Florian Westphal <fw@...len.de>
To:	David Miller <davem@...emloft.net>
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

David Miller <davem@...emloft.net> wrote:
> From: Florian Westphal <fw@...len.de>
> Date: Sat, 11 Jun 2016 12:46:04 +0200
> 
> > sch_atm returns this when TC_ACT_SHOT classification occurs.
> > 
> > But all other schedulers that use tc_classify
> > (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS
> > in this case so just do that in atm.
> 
> Yes, but it's been like this for two decades.
> 
> One of the points of my reply to the previous version of this
> patch is that indeed it is explicitly returned, intentionally.

But nothing evaluates it?

Only exception is pktgen which treats it line _CN and _DROP...

[ But I dont mind if you'd rather leave it alone, I just find it
  silly we have a NET_XMIT_ that has no clear meaning or use ]