netdev - RE: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB1855C3B3CF0634BAE6D8063CFF520@VI1PR0401MB1855.eurprd04.prod.outlook.com>
Date:	Sun, 12 Jun 2016 05:16:02 +0000
From:	Fugang Duan <fugang.duan@....com>
To:	Stefan Wahren <stefan.wahren@...e.com>,
	David Miller <davem@...emloft.net>
CC:	Fabio Estevam <fabio.estevam@....com>,
	Lucas Stach <l.stach@...gutronix.de>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"holgerschurig@...il.com" <holgerschurig@...il.com>,
	Troy Kisky <troy.kisky@...ndarydevices.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next RFT] net: fec: handle small PHY reset durations
 more precisely

From: Stefan Wahren <stefan.wahren@...e.com> Sent: Thursday, June 09, 2016 4:43 AM
> To: David Miller <davem@...emloft.net>; Fugang Duan
> <fugang.duan@....com>
> Cc: Fabio Estevam <fabio.estevam@....com>; Lucas Stach
> <l.stach@...gutronix.de>; andrew@...n.ch; holgerschurig@...il.com; Troy
> Kisky <troy.kisky@...ndarydevices.com>; linux-arm-kernel@...ts.infradead.org;
> netdev@...r.kernel.org; Stefan Wahren <stefan.wahren@...e.com>
> Subject: [PATCH net-next RFT] net: fec: handle small PHY reset durations more
> precisely
> 
> Since msleep is based on jiffies the PHY reset could take longer than expected.
> So use msleep for values greater than 20 msec otherwise usleep_range.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 3c0255e..49f8055 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3191,7 +3191,12 @@ static void fec_reset_phy(struct platform_device
> *pdev)
>  		dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
>  		return;
>  	}
> -	msleep(msec);
> +
> +	if (msec > 20)
> +		msleep(msec);
> +	else
> +		usleep_range(msec * 1000, msec * 1000 + 1000);
> +
>  	gpio_set_value_cansleep(phy_reset, !active_high);  }  #else /*
> CONFIG_OF */
> --
> 1.7.9.5

Thanks. You are correct base on Documentation/timers/timers-howto.txt.

Acked-by: Fugang Duan <fugang.duan@....com>