netdev - Re: [RFC PATCH iproute2] tc: let m_ipt work with new iptables API headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e654b82-2e16-7a5e-62cc-c137b7b75a5c@pengutronix.de>
Date:	Sun, 12 Jun 2016 23:30:40 +0200
From:	Alexander Aring <aar@...gutronix.de>
To:	netdev@...r.kernel.org
Cc:	kernel@...gutronix.de, clemens.gruber@...ruber.com
Subject: Re: [RFC PATCH iproute2] tc: let m_ipt work with new iptables API
 headers


Hi,

On 05/29/2016 08:27 PM, Alexander Aring wrote:
> Since commit 5cd1adb ("Update to current iptables headers") the build
> with m_ipt.o and the following config will fail:
> 
> TC_CONFIG_XT:=n
> TC_CONFIG_XT_OLD:=n
> TC_CONFIG_XT_OLD_H:=n
> 
> This patch renames "iptables_target" to "xtables_target" and some other
> things which gets renamed and I noticed while reading iptables git log.
> Functions which are not used in m_ipt.c and not exported by the header
> are removed, if they still used in m_ipt.c I added a static to the function.
> 
> Reported-by: Clemens Gruber <clemens.gruber@...ruber.com>
> Signed-off-by: Alexander Aring <aar@...gutronix.de>
> ---
> I removed also "linux/if.h" because some redifinition errors and seems
> not be necessary anymore.
> 
> I didn't test this implementation, I just fix the compile issues at m_ipt
> implementation according to the algoritmn described above.
> 
> Maybe there are more TC_CONFIG_XT* config variants broken than just m_ipt?
> 

ping, any comments to this patch?
I can rebase and resend this patch if necessary.

- Alex