netdev - Re: [PATCH net v2] ipv6: fix checksum annotation in udp6_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWJNCE44ZhqWedzpK36yCmvJJx_o9Eg9HYs42=7y+-41w@mail.gmail.com>
Date:	Sat, 11 Jun 2016 18:07:29 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net v2] ipv6: fix checksum annotation in udp6_csum_init

On Sat, Jun 11, 2016 at 12:15 PM, Hannes Frederic Sowa
<hannes@...essinduktion.org> wrote:
> Cc: Tom Herbert <tom@...bertland.com>
> Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6")
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---
>  net/ipv6/ip6_checksum.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
> index b2025bf3da4af2..c0cbcb259f5a9a 100644
> --- a/net/ipv6/ip6_checksum.c
> +++ b/net/ipv6/ip6_checksum.c
> @@ -78,9 +78,12 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
>          * we accept a checksum of zero here. When we find the socket
>          * for the UDP packet we'll check if that socket allows zero checksum
>          * for IPv6 (set by socket option).
> +        *
> +        * Note, we are only interested in != 0 or == 0, thus the
> +        * force to int.
>          */
> -       return skb_checksum_init_zero_check(skb, proto, uh->check,
> -                                          ip6_compute_pseudo);
> +       return (__force int)skb_checksum_init_zero_check(skb, proto, uh->check,
> +                                                        ip6_compute_pseudo);

Same for udp4_csum_init() ?