netdev - Re: udp failures traced to e858fae2b0b8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <973d7528-2ea7-47e3-cf19-208c24d85dec@cumulusnetworks.com>
Date:	Mon, 13 Jun 2016 13:56:05 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: udp failures traced to e858fae2b0b8

On 6/13/16 12:40 PM, Mike Rapoport wrote:
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9af0a98..9f8be96 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -482,10 +482,6 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
>  	if (hdr->hdr.flags & VIRTIO_NET_HDR_F_DATA_VALID)
>  		skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> -	skb->protocol = eth_type_trans(skb, dev);
> -	pr_debug("Receiving skb proto 0x%04x len %i type %i\n",
> -		 ntohs(skb->protocol), skb->len, skb->pkt_type);
> -
>  	if (virtio_net_hdr_to_skb(skb, &hdr->hdr,
>  				  virtio_is_little_endian(vi->vdev))) {
>  		net_warn_ratelimited("%s: bad gso: type: %u, size: %u\n",
> @@ -494,6 +490,10 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
>  		goto frame_err;
>  	}
>
> +	skb->protocol = eth_type_trans(skb, dev);
> +	pr_debug("Receiving skb proto 0x%04x len %i type %i\n",
> +		 ntohs(skb->protocol), skb->len, skb->pkt_type);
> +
>  	napi_gro_receive(&rq->napi, skb);
>  	return;
>
>

Fixes the problem.