netdev - Re: [PATCH RFC 2/3] ipv4: make flow functions more grepable by removing flowi4_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <814da6cb-cb7f-ee72-718c-3bb0fd14753d@cumulusnetworks.com>
Date:	Mon, 13 Jun 2016 16:03:58 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	netdev@...r.kernel.org
Cc:	ja@....bg
Subject: Re: [PATCH RFC 2/3] ipv4: make flow functions more grepable by
 removing flowi4_update_output

On 6/13/16 2:47 PM, Hannes Frederic Sowa wrote:
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---
>  include/net/flow.h              | 11 -----------
>  include/net/route.h             |  8 ++++----
>  net/netfilter/ipvs/ip_vs_xmit.c |  9 +++++++--
>  net/sctp/protocol.c             | 10 ++++------
>  4 files changed, 15 insertions(+), 23 deletions(-)
>
> diff --git a/include/net/flow.h b/include/net/flow.h
> index 2c8e95b987c98c..6276a81f7b3d13 100644
> --- a/include/net/flow.h
> +++ b/include/net/flow.h
> @@ -90,17 +90,6 @@ struct flowi4 {
>  #define fl4_gre_key		uli.gre_key
>  } __attribute__((__aligned__(BITS_PER_LONG/8)));
>
> -/* Reset some input parameters after previous lookup */
> -static inline void flowi4_update_output(struct flowi4 *fl4, int oif, __u8 tos,
> -					__be32 daddr, __be32 saddr)
> -{
> -	fl4->flowi4_oif = oif;
> -	fl4->flowi4_tos = tos;
> -	fl4->daddr = daddr;
> -	fl4->saddr = saddr;
> -}
> -				
> -

Ditto with this helper. Glad to see it go.

Change LGTM. Reviewed-by: David Ahern <dsa@...ulusnetworks.com>