netdev - Re: [PATCH v2 -next] sched: remove NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160612.220237.1542237134488036412.davem@davemloft.net>
Date:	Sun, 12 Jun 2016 22:02:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sat, 11 Jun 2016 17:14:09 -0700

> On Sat, Jun 11, 2016 at 3:54 PM, David Miller <davem@...emloft.net> wrote:
>> From: Florian Westphal <fw@...len.de>
>> Date: Sat, 11 Jun 2016 12:46:04 +0200
>>
>>> sch_atm returns this when TC_ACT_SHOT classification occurs.
>>>
>>> But all other schedulers that use tc_classify
>>> (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS
>>> in this case so just do that in atm.
>>
>> Yes, but it's been like this for two decades.
>>
>> One of the points of my reply to the previous version of this
>> patch is that indeed it is explicitly returned, intentionally.
> 
> I think this is a leftover from CONFIG_NET_CLS_POLICE removal.
> 
> BTW, probably TC_POLICE_* can be removed together.

Ok I'll apply this.