netdev - Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465815798.2313.13.camel@pengutronix.de>
Date:	Mon, 13 Jun 2016 13:03:18 +0200
From:	Lucas Stach <l.stach@...gutronix.de>
To:	Joshua Clayton <stillcompiling@...il.com>
Cc:	Russell King - ARM Linux <linux@...linux.org.uk>,
	devicetree@...r.kernel.org, Fugang Duan <fugang.duan@....com>,
	netdev@...r.kernel.org, patchwork-lst@...gutronix.de,
	kernel@...gutronix.de, Shawn Guo <shawnguo@...nel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW
 workaround for ERR006687

Am Dienstag, den 07.06.2016, 12:46 -0700 schrieb Joshua Clayton:
> On Thu, 02 Jun 2016 10:25:06 +0200
> Lucas Stach <l.stach@...gutronix.de> wrote:
> 
> > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM
> > Linux:
> > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote:  
> > > > @@ -97,6 +97,7 @@
> > > >  	phy-reset-gpios = <&gpio3 31 0>;
> > > >  	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> > > >  			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> > > > +	fsl,err006687-war-present;  
> > > 
> 
> Why can't we just have the quirk detect the interrupts-extended
> property, which is not present on boards without the workaround.
> Wouldn't that be better? No dts change needed.
> 
I pondered that idea too, but have gone with the solution presented in
this patch series as it's more explicit and - with far more weight to it
- does not require the driver to touch DT properties that are outside of
its domain of responsibility. The "interrupts-extended" properties are
not meant to be parsed by the driver, but rather the IRQ subsystem.

Regards,
Lucas