netdev - Re: [PATCH net-next v3 5/7] vmxnet3: add support for get_coalesce, set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465916652.3529.242.camel@decadent.org.uk>
Date:	Tue, 14 Jun 2016 16:04:12 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Shrikrishna Khare <skhare@...are.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, pv-drivers@...are.com
Cc:	Keyong Sun <sunk@...are.com>, Manoj Tammali <tammalim@...are.com>
Subject: Re: [PATCH net-next v3 5/7] vmxnet3: add support for get_coalesce,
 set_coalesce ethtool operations

On Mon, 2016-06-13 at 18:50 -0700, Shrikrishna Khare wrote:
[...]
> --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
> @@ -725,6 +725,164 @@ vmxnet3_set_rss(struct net_device *netdev, const u32 *p, const u8 *key,
>  }
>  #endif
>  
> +static int
> +vmxnet3_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec)
> +{
> +	struct vmxnet3_adapter *adapter = netdev_priv(netdev);
> +
> +	if (!VMXNET3_VERSION_GE_3(adapter))
> +		return -EOPNOTSUPP;
> +
> +	memset(ec, 0, sizeof(struct ethtool_coalesce));
[...]

The ethtool core already clears the structure, and it sets the cmd
field properly.  This memset() should be removed.

Otherwise I think this is fine.

Ben.
 
-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert
Camus

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)