netdev - Re: [CRIU] TCP_REPAIR MSS issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614205741.GB20722@outlook.office365.com>
Date:	Tue, 14 Jun 2016 14:21:28 -0700
From:	Andrey Vagin <avagin@...tuozzo.com>
To:	"Eggert, Lars" <lars@...app.com>
CC:	Pavel Emelyanov <xemul@...tuozzo.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"criu@...nvz.org" <criu@...nvz.org>,
	"Honda, Michio" <michio@...app.com>
Subject: Re: [CRIU] TCP_REPAIR MSS issue

On Tue, Jun 14, 2016 at 07:37:12PM +0000, Eggert, Lars wrote:
> Hi,
> 
> On 2016-06-14, at 19:15, Andrey Vagin <avagin@...tuozzo.com> wrote:
> > Recently we found that we have to restore more parameters for tcp
> > sockets.
> > https://patchwork.kernel.org/patch/9144995/
> 
> thanks for the pointer.
> 
> > As for your problem, criu saves and restores mss_clamp. Could you check
> > that it works for your case?
> 
> I do this already, but clamping doesn't help here, since it only limits the MSS (but does not increase it from the minimum.)

Yes, you are right.

On my host, I see that dst is set in tcp_v4_connect() -> sk_setup_caps()

> 
> Lars