netdev - Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fdr1kwi.fsf@ketchup.mtl.sfl>
Date:	Tue, 14 Jun 2016 18:10:53 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

>> -	name = info->name;
>> +	dev_info(dev, "switch 0x%x detected: %s, revision %u\n", prod_num,
>> +		 info->name, rev);
>>  
>> -	ps = devm_kzalloc(dsa_dev, sizeof(*ps), GFP_KERNEL);
>> +	ps = devm_kzalloc(dev, sizeof(*ps), GFP_KERNEL);
>>  	if (!ps)
>>  		return NULL;
>
> I don't like the way this detect function goes a lot further than
> detection. I would say detection finished when you have the info
> structure. Return at that point, and let the probe do the rest.

OK, I split detection and allocation.

Thanks,

        Vivien