netdev - Re: [PATCH net-next] virtio_net: fix csum generation for virtio-net devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160614.030406.185717833189171632.davem@davemloft.net>
Date:	Tue, 14 Jun 2016 03:04:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	rppt@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, mst@...hat.com, dsa@...ulusnetworks.com
Subject: Re: [PATCH net-next] virtio_net: fix csum generation for
 virtio-net devices

From: Mike Rapoport <rppt@...ux.vnet.ibm.com>
Date: Tue, 14 Jun 2016 08:29:38 +0300

> The commit e858fae2b0b8 ("virtio_net: use common code for virtio_net_hdr
> and skb GSO conversion") replaced the tun code for header manipulation
> with the generic helpers. While doing so, it implictly moved the
> skb_partial_csum_set() invocation after eth_type_trans(), which
> invalidate the current gso start/offset values.
> Fix it by moving the helper invocation before the mac pulling.
> 
> Fixes: e858fae2b0b8 ("virtio_net: use common code for virtio_net_hdr and
> skb GSO conversion")
> 
> Reported-by: David Ahern <dsa@...ulusnetworks.com>
> Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>

Applied.