netdev - RE: [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 07:23:54 +0000
From:	Ramesh Shanmugasundaram <ramesh.shanmugasundaram@...renesas.com>
To:	Ulrich Hecht <ulrich.hecht@...il.com>
CC:	"mkl@...gutronix.de" <mkl@...gutronix.de>,
	"wg@...ndegger.com" <wg@...ndegger.com>,
	"socketcan@...tkopp.net" <socketcan@...tkopp.net>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Chris Paterson <Chris.Paterson2@...esas.com>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	"linux-renesas-soc@...r.kernel.org" 
	<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Ulrich,

> Thanks for the patch, this is a lot easier to handle.
> 
[...]
> > +#define RCANFD_RFPTR_RFTS(x)           (((x) >> 0) & 0xff)
> 
> That should be "(((x) >> 0) & 0xffff)".
> 
> > +
[...]

> > +/* RSCFDnCFDRMXXXq -> RCANFD_F_RMXXX(q) */
> > +#define RCANFD_F_RMID(q)               (0x2000 + (0x10 * (q)))
> > +#define RCANFD_F_RMPTR(q)              (0x2004 + (0x10 * (q)))
> > +#define RCANFD_F_RMFDSTS(q)            (0x2008 + (0x10 * (q)))
> 
> These should all be "+ (0x20 * (q))".
> 
[...]
> 
> Apart from that, all register addresses, offsets, bit positions and masks
> check out. With the two issues fixed:
> 
> Reviewed-by: Ulrich Hecht <ulrich.hecht+renesas@...il.com>

Thank you for your time & review comments. I have fixed these typos and sent out a v7 patch set adding your Reviewed-by tag.

Thanks,
Ramesh