netdev - Re: [PATCH v8 4/5] ptr_ring: resize support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160614140428.7fb2bd94@redhat.com>
Date:	Tue, 14 Jun 2016 14:04:28 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
	Eric Dumazet <eric.dumazet@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	kvm@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH v8 4/5] ptr_ring: resize support

On Mon, 13 Jun 2016 23:54:45 +0300
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> This adds ring resize support. Seems to be necessary as
> users such as tun allow userspace control over queue size.
> 
> If resize is used, this costs us ability to peek at queue without
> consumer lock - should not be a big deal as peek and consumer are
> usually run on the same CPU.
> 
> If ring is made bigger, ring contents is preserved.  If ring is made
> smaller, extra pointers are passed to an optional destructor callback.
> 
> Cleanup function also gains destructor callback such that
> all pointers in queue can be cleaned up.
> 
> This changes some APIs but we don't have any users yet,
> so it won't break bisect.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer