netdev - Re: [PATCH -next] sctp: fix error return code in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614132136.GA32288@hmsreliant.think-freely.org>
Date:	Tue, 14 Jun 2016 09:21:36 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Xin Long <lucien.xin@...il.com>
Cc:	weiyj_lk@....com, Vlad Yasevich <vyasevich@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-sctp@...r.kernel.org, network dev <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] sctp: fix error return code in sctp_init()

On Tue, Jun 14, 2016 at 11:04:05AM +0800, Xin Long wrote:
> On Mon, Jun 13, 2016 at 11:08 PM,  <weiyj_lk@....com> wrote:
> > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > ---
> >  net/sctp/protocol.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> > index 40022ee..3b56ae5 100644
> > --- a/net/sctp/protocol.c
> > +++ b/net/sctp/protocol.c
> > @@ -1479,7 +1479,8 @@ static __init int sctp_init(void)
> >                 INIT_HLIST_HEAD(&sctp_port_hashtable[i].chain);
> >         }
> >
> > -       if (sctp_transport_hashtable_init())
> > +       status = sctp_transport_hashtable_init();
> > +       if (status)
> >                 goto err_thash_alloc;
> >
> >         pr_info("Hash tables configured (bind %d/%d)\n", sctp_port_hashsize,
> >
> >
> Acked-by: Xin Long <lucien.xin@...il.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Acked-by: Neil Horman <nhorman@...driver.com>