netdev - Re: [PATCH net] htb: call qdisc_root with rcu read lock held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 18:26:05 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] htb: call qdisc_root with rcu read lock held

On Mon, Jun 13, 2016 at 9:16 PM, Florian Westphal <fw@...len.de> wrote:
> saw a debug splat:
> net/include/net/sch_generic.h:287 suspicious rcu_dereference_check() usage!
> other info that might help us debug this:
> rcu_scheduler_active = 1, debug_locks = 0
>  2 locks held by kworker/2:1/710:
>   #0:  ("events"){.+.+.+}, at: [<ffffffff8106ca1d>]
>   #1:  ((&q->work)){+.+...}, at: [<ffffffff8106ca1d>] process_one_work+0x14d/0x690
> Workqueue: events htb_work_func
> Call Trace:
>  [<ffffffff812dc763>] dump_stack+0x85/0xc2
>  [<ffffffff8109fee7>] lockdep_rcu_suspicious+0xe7/0x120
>  [<ffffffff814ced47>] htb_work_func+0x67/0x70
>
> Signed-off-by: Florian Westphal <fw@...len.de>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>