netdev - Re: [PATCH net-next] tun: fix csum generation for tap devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160615.140057.269655953482473722.davem@davemloft.net>
Date:	Wed, 15 Jun 2016 14:00:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pabeni@...hat.com
Cc:	netdev@...r.kernel.org, mst@...hat.com, rppt@...ux.vnet.ibm.com,
	hannes@...essinduktion.org
Subject: Re: [PATCH net-next] tun: fix csum generation for tap devices

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 14 Jun 2016 00:00:04 +0200

> The commit 34166093639b ("tuntap: use common code for virtio_net_hdr
> and skb GSO conversion") replaced the tun code for header manipulation
> with the generic helpers. While doing so, it implictly moved the
> skb_partial_csum_set() invocation after eth_type_trans(), which
> invalidate the current gso start/offset values.
> Fix it by moving the helper invocation before the mac pulling.
> 
> Fixes: 34166093639 ("tuntap: use common code for virtio_net_hdr and skb GSO conversion")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.