netdev - Re: [PATCH net-next 01/10] net_sched: add the ability to defer skb freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+d-vVeMoDPhAkfZw0Y_=ST9UmBto00Afs=Jzh8gR8NyA@mail.gmail.com>
Date:	Wed, 15 Jun 2016 05:39:07 -0700
From:	Eric Dumazet <edumazet@...gle.com>
To:	Jesper Dangaard Brouer <brouer@...hat.com>
Cc:	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 01/10] net_sched: add the ability to defer skb freeing

On Wed, Jun 15, 2016 at 5:33 AM, Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
> On Mon, 13 Jun 2016 20:21:50 -0700
>
>
> This looks a lot like kfree_skb_list()....
>
> What about bulk free'ing SKBs here?

We are in a very slow path here. Once in a while a potentially huge
qdisc is dismantled.

The important point is to free these skbs outside of any mutex/lock/bh
, not gain 5% on the actual freeing ;)

Now if you have a use case where these operations happen often enough,
then I believe you have a problem you need to fix !